gnodet commented on code in PR #199:
URL:
https://github.com/apache/maven-integration-testing/pull/199#discussion_r972026490
##########
core-it-support/maven-it-helper/src/main/java/org/apache/maven/it/AbstractMavenIntegrationTestCase.java:
##########
@@ -568,33 +568,19 @@ protected Verifier newVerifier( String basedir, String
settings, boolean debug )
String path = settingsFile.getAbsolutePath();
- // dedicated CLI option only available since MNG-3914
- if ( matchesVersionRange( "[2.1.0,)" ) )
+ verifier.addCliOption( "--global-settings" );
+ if ( path.indexOf( ' ' ) < 0 )
{
- verifier.addCliOption( "--global-settings" );
- if ( path.indexOf( ' ' ) < 0 )
- {
- verifier.addCliOption( path );
- }
- else
- {
- verifier.addCliOption( '"' + path + '"' );
- }
+ verifier.addCliOption( path );
}
else
{
- verifier.getSystemProperties().put(
"org.apache.maven.global-settings", path );
+ verifier.addCliOption( '"' + path + '"' );
}
Review Comment:
Sounds like a plan to me !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]