[ 
https://issues.apache.org/jira/browse/MBUILDCACHE-22?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17604680#comment-17604680
 ] 

ASF GitHub Bot commented on MBUILDCACHE-22:
-------------------------------------------

AlexanderAshitkin commented on code in PR #24:
URL: 
https://github.com/apache/maven-build-cache-extension/pull/24#discussion_r970801687


##########
src/main/java/org/apache/maven/buildcache/BuildCacheMojosExecutionStrategy.java:
##########
@@ -104,9 +106,9 @@ public void execute( List<MojoExecution> mojoExecutions,
                 mojoExecutionRunner.run( mojoExecution );
             }
             cacheState = cacheConfig.initialize();
-            if ( cacheState == INITIALIZED )
+            if ( cacheState == INITIALIZED || skipCacheLookup )
             {
-                result = cacheController.findCachedBuild( session, project, 
mojoExecutions );
+                result = cacheController.findCachedBuild( session, project, 
mojoExecutions, skipCacheLookup );

Review Comment:
   right now cache could be accessed when no initialized it seems
   





> Add possibility to skip cache lookup
> ------------------------------------
>
>                 Key: MBUILDCACHE-22
>                 URL: https://issues.apache.org/jira/browse/MBUILDCACHE-22
>             Project: Maven Build Cache Extension
>          Issue Type: New Feature
>          Components: remote build cache
>    Affects Versions: 1.0.0-alpha
>            Reporter: Alexander Eltsov
>            Priority: Major
>              Labels: pull-request-available
>
> Add ability to skip cache lookup for a particular module or whole project 
> (required to get some modules always built e.g. via a profile - e.g. I have 
> some additional artifacts published by CI).
> Alternatively it allows an easy "force" rebuild of a whole project
> The difference with not using cache is that results are put into cache, just 
> current matching versions are not taken from caches



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to