[ 
https://issues.apache.org/jira/browse/MSHARED-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601958#comment-17601958
 ] 

Slawomir Jaranowski commented on MSHARED-1130:
----------------------------------------------

The root cause is in method of {{PatternIncludesArtifactFilter}}

{code}
    private static Artifactoid adapt( final Artifact artifact )
    {
        requireNonNull( artifact );
        return coordinate ->
        {
            requireNonNull( coordinate );
            switch ( coordinate )
            {
                case GROUP_ID:
                    return artifact.getGroupId();
                case ARTIFACT_ID:
                    return artifact.getArtifactId();
                case BASE_VERSION:
                    return artifact.getBaseVersion();
                case CLASSIFIER:
                    return artifact.hasClassifier() ? artifact.getClassifier() 
: null;
                case TYPE:
                    return artifact.getType();
                default:
            }
            throw new IllegalArgumentException( "unknown coordinate: " + 
coordinate );
        };
    }
{code}

for empty {{Classifier}} null is returned.



> PatternIncludesArtifactFilters raising NPE for patterns w/ wildcards and 
> artifactoid w/ null on any coordinate
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: MSHARED-1130
>                 URL: https://issues.apache.org/jira/browse/MSHARED-1130
>             Project: Maven Shared Components
>          Issue Type: Bug
>          Components: maven-common-artifact-filters
>    Affects Versions: maven-common-artifact-filters-3.3.1
>            Reporter: Andrzej Jarmoniuk
>            Priority: Major
>
> Encountered an NPE from {{PatternIncludesArtifactFilters.match}} if the 
> pattern includes wildcards and the artifactoid returns null on any of its 
> coordinates.
> In such cases, the {{value}} argument will be null, which will lead to an NPE 
> when it's being dereferenced in line 653.
> This led to https://github.com/mojohaus/versions-maven-plugin/issues/673
> In this case, {{token}} was {{JET*-SNAPSHOT}} and {{value}} as returned from 
> the artifactoid was null.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to