kwin commented on code in PR #139:
URL: https://github.com/apache/maven-plugin-tools/pull/139#discussion_r956313386
##########
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/AbstractGeneratorMojo.java:
##########
@@ -88,44 +81,7 @@ public void execute()
return;
}
- if ( !"maven-plugin".equalsIgnoreCase( project.getArtifactId() )
- && project.getArtifactId().toLowerCase().startsWith( "maven-" )
- && project.getArtifactId().toLowerCase().endsWith( "-plugin" )
- && !"org.apache.maven.plugins".equals( project.getGroupId() ) )
- {
- getLog().error( LS + LS + "Artifact Ids of the format
maven-___-plugin are reserved for" + LS
- + "plugins in the Group Id
org.apache.maven.plugins" + LS
- + "Please change your artifactId to the format
___-maven-plugin" + LS
- + "In the future this error will break the
build." + LS + LS );
- }
Review Comment:
Logging it more than once is a bit redundant and you always need to run
descriptor after helpmojo anyways. Therefore just logging in descriptor seems
to be enough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
