andreybpanfilov commented on PR #768:
URL: https://github.com/apache/maven/pull/768#issuecomment-1208044703

   @michael-o 
   
   > You consider this change pointless?
   
   The idea of maintaining pool of immutable objects is good, however the 
implementation proposed isn't: the JVM is free to cleanup `dependencyCache` as 
soon as execution leaves `#toDependency` method - there are no more references 
to `depCacheKeykey`. The author is observing some performance improvements just 
because his JVM has enough free memory to not trigger GC whilst maven builds 
dependency graph (give JVM more memory to save memory).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to