slawekjaranowski commented on code in PR #126:
URL: https://github.com/apache/maven-plugin-tools/pull/126#discussion_r928800853
##########
maven-plugin-annotations/src/main/java/org/apache/maven/plugins/annotations/Parameter.java:
##########
@@ -72,6 +72,13 @@
*/
String defaultValue() default "";
+ /**
+ * Defines the implementation in the case the parameter type is an
interface.
+ *
+ * @return the implementation class name
+ */
+ Class<?> implementation() default Object.class;
Review Comment:
Ok, I think it is never mind (probably) if implementation will be string or
class for `parameter` annotation is used in plugin itself not in plugin
configuration.
Finally class must be on plugin classpath.
We also have `implementation` attribute for configuration ...
https://maven.apache.org/guides/mini/guide-configuring-plugins.html#mapping-complex-objects
Now I don't know which one wins implementation from parameter annotation /
javadoc tags ... or from configuration ...
😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
