michael-o commented on code in PR #126:
URL: https://github.com/apache/maven-plugin-tools/pull/126#discussion_r928782410


##########
maven-plugin-annotations/src/main/java/org/apache/maven/plugins/annotations/Parameter.java:
##########
@@ -72,6 +72,13 @@
      */
     String defaultValue() default "";
 
+    /**
+     * Defines the implementation in the case the parameter type is an 
interface.
+     *
+     * @return the implementation class name
+     */
+    Class<?> implementation() default Object.class;

Review Comment:
   I don't agree here. The `role` is the interface, no? The hint is the named 
impl as a string. I don't think that it compares. Am I wrong?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to