[
https://issues.apache.org/jira/browse/SCM-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563915#comment-17563915
]
ASF GitHub Bot commented on SCM-807:
------------------------------------
kwin commented on PR #152:
URL: https://github.com/apache/maven-scm/pull/152#issuecomment-1178024189
I only added a test for `ScmManager.add(...)` and `ScmManager.checkIn(...)`.
All other `ScmManager` methods which return file paths and take a `ScmFileSet`
should be checked as well. They should IMHO all behave the same (either all
always relative to the working copy root or all relative to the passed
`ScmFileSet.getBasedir()`)
> JGit impl check-in fails unless the Maven project is in the working copy root
> -----------------------------------------------------------------------------
>
> Key: SCM-807
> URL: https://issues.apache.org/jira/browse/SCM-807
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-gitexe
> Affects Versions: 1.9.4
> Reporter: Richard DiCroce
> Priority: Major
> Attachments: scm-807.txt
>
>
> Another problem exposed by maven-release-plugin: the JGit SCM
> implementation's check-in fails unless the Maven project is in the working
> copy root because it confuses the working copy's location with the Maven
> project's location.
> The attached patch resolves the issue. Combined with the patch attached to
> SCM-806, release:prepare now mostly succeeds with the JGit implementation.
> There is still a problem with the POM not being transformed correctly, but
> that's a problem in maven-release-plugin.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
