[ https://issues.apache.org/jira/browse/MWRAPPER-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17562288#comment-17562288 ]
ASF GitHub Bot commented on MWRAPPER-67: ---------------------------------------- hazendaz commented on code in PR #44: URL: https://github.com/apache/maven-wrapper/pull/44#discussion_r913267565 ########## maven-wrapper-distribution/src/resources/mvnw: ########## @@ -192,7 +192,8 @@ else wrapperUrl="https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/@@project.version@@/maven-wrapper-@@project.version@@.jar" fi while IFS="=" read key value; do - case "$key" in (wrapperUrl) wrapperUrl="$value"; break ;; + # Remove invalid line endings from value + case "$key" in (wrapperUrl) wrapperUrl="${value%$'\r'}"; break ;; Review Comment: @michael-o When you get a chance, can you check in on this again? Thanks. > mvnw script does not download jar if used in git bash in windows > ---------------------------------------------------------------- > > Key: MWRAPPER-67 > URL: https://issues.apache.org/jira/browse/MWRAPPER-67 > Project: Maven Wrapper > Issue Type: Bug > Components: Maven Wrapper Scripts > Affects Versions: 3.1.1 > Reporter: Jeremy Landis > Priority: Minor > > Usage of git bash will not download the maven wrapper jar along with curl > (probably others) due to having windows line endings in the URL (trailing). > To ensure that is not the case, make sure to strip invalid line endings out > before usage. > Use case, ./mvnw in powershell will use mvnw.cmd and has no issues > downloading. If user does same in git bash, it will fail with invalid URL > error with curl. Using ./mvnw.cmd there will work but not natural usage. To > ensure this simply just works for full support, trim out invalid line feeds. > note: This only affected the download. It worked otherwise. -- This message was sent by Atlassian Jira (v8.20.10#820010)