michael-o commented on code in PR #149:
URL: https://github.com/apache/maven-scm/pull/149#discussion_r882444380
##########
maven-scm-plugin/src/test/java/org/apache/maven/scm/plugin/CheckoutMojoTest.java:
##########
@@ -81,6 +81,12 @@ public void testSkipCheckoutWithConnectionUrl()
SvnScmTestUtils.initializeRepository( repository );
+ if ( !ScmTestCase.isSystemCmd( SvnScmTestUtils.SVN_COMMAND_LINE ) )
+ {
+ ScmTestCase.printSystemCmdUnavail(
SvnScmTestUtils.SVN_COMMAND_LINE, getName() );
+ return;
+ }
+
Review Comment:
There is a problem, I have a local branch which uses your new code:
```diff
diff --git
a/maven-scm-plugin/src/test/java/org/apache/maven/scm/plugin/BranchMojoTest.java
b/maven-scm-plugin/src/test/java/org/apache/maven/scm/plugin/BranchMojoTest.java
index ef788478..33d27e7f 100644
---
a/maven-scm-plugin/src/test/java/org/apache/maven/scm/plugin/BranchMojoTest.java
+++
b/maven-scm-plugin/src/test/java/org/apache/maven/scm/plugin/BranchMojoTest.java
@@ -27,6 +27,9 @@
import java.io.File;
+import static
org.apache.maven.scm.provider.svn.SvnScmTestUtils.SVN_COMMAND_LINE;
+import static
org.apache.maven.scm.provider.svn.SvnScmTestUtils.SVNADMIN_COMMAND_LINE;
+
/**
* @author <a href="mailto:eveni...@apache.org";>Emmanuel Venisse</a>
*
@@ -51,11 +54,7 @@ protected void setUp()
FileUtils.forceDelete( repository );
- if ( !ScmTestCase.isSystemCmd(
SvnScmTestUtils.SVNADMIN_COMMAND_LINE ) )
- {
- ScmTestCase.printSystemCmdUnavail(
SvnScmTestUtils.SVNADMIN_COMMAND_LINE, "setUp" );
- return;
- }
+ ScmTestCase.checkScmPresence( SVNADMIN_COMMAND_LINE );
SvnScmTestUtils.initializeRepository( repository );
```
But all of these changes fail with `AssertionViolationException`. There is
some old code in Plugin Testing which does not work with `Assume`. Therefore,
I'd like to move on with this and analyze it in a subsequent ticket:
https://issues.apache.org/jira/projects/SCM/issues/SCM-939
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
