nielsbasjes commented on code in PR #149:
URL: https://github.com/apache/maven-scm/pull/149#discussion_r882435884
##########
maven-scm-plugin/src/test/java/org/apache/maven/scm/plugin/CheckoutMojoTest.java:
##########
@@ -81,6 +81,12 @@ public void testSkipCheckoutWithConnectionUrl()
SvnScmTestUtils.initializeRepository( repository );
+ if ( !ScmTestCase.isSystemCmd( SvnScmTestUtils.SVN_COMMAND_LINE ) )
+ {
+ ScmTestCase.printSystemCmdUnavail(
SvnScmTestUtils.SVN_COMMAND_LINE, getName() );
+ return;
+ }
+
Review Comment:
- I see this code fragment duplicated many times. Should we make this into a
method that returns a boolean?
- If svn is missing then this test will pass. Now tests can pass, fail or be
skipped. In many of the cases here I would have chosen to mark them as skipped
instead of (as I read the code) passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
