[ 
https://issues.apache.org/jira/browse/DOXIA-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17539048#comment-17539048
 ] 

Michael Osipov commented on DOXIA-590:
--------------------------------------

So there are the spots need to be addressed:
 !screenshot-1.png! 

[~fe2417], I do agree. In those places the semantics of the attribute needs to 
be retained since attributes are passed and the caller could have already 
supplied it. I will provide a PR for that.

> Either provided element class or default class gets ignored
> -----------------------------------------------------------
>
>                 Key: DOXIA-590
>                 URL: https://issues.apache.org/jira/browse/DOXIA-590
>             Project: Maven Doxia
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.8
>            Reporter: Fred Eckertson
>            Priority: Major
>             Fix For: wontfix-candidate, 2.0.0-M3
>
>         Attachments: screenshot-1.png
>
>
> The following construct is somewhat common in doxia-core
> att.addAttribute( Attribute.CLASS, "a" );
> The documentation says that basic attributes (including CLASS) are supported. 
> However in cases like this either that "a" or the CLASS that was provided in 
> the attributes parameter will be ignored. The correct way to do this is to 
> append the provided CLASS to "a " if a CLASS attribute was provided.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to