[ 
https://issues.apache.org/jira/browse/SUREFIRE-2063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526808#comment-17526808
 ] 

Maarten Mulders commented on SUREFIRE-2063:
-------------------------------------------

{quote}Would it be sufficient to only replace tabs with spaces?
{quote}

I think the first implementation of the fix did just that, and then we decided 
([pretty 
last-minute|https://github.com/apache/maven-surefire/compare/14ab570030945063d774f73d731edab8796e55f1..71a173ddaf0a8dc9ee68e3720ca9f9c208492b65])
 to go for the "replace all whitespace".

[~tibordigana], what do you think? Should we go back to the initial idea of 
replacing {{"\n"}}, {{"\r"}} and {{"\t"}} only?

> Adding argLine with tab characters fails
> ----------------------------------------
>
>                 Key: SUREFIRE-2063
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-2063
>             Project: Maven Surefire
>          Issue Type: Bug
>    Affects Versions: 3.0.0-M6
>            Reporter: Daniel Subelman
>            Assignee: Maarten Mulders
>            Priority: Blocker
>             Fix For: 3.0.0-M7
>
>
> Since v3.3.0-M6 fails when using <argLine> to export or open a package. The 
> failure is produced when using --add-opens or --add-exports in <argLine>.
> The execution doesn't fail with v3.3.0-M5 or earlier.
> As an example, it fails when using the following <argLine>:
> {code:java}
> <argLine>
>     --add-opens 
> org.junit.platform.commons/org.junit.platform.commons.util=ALL-UNNAMED
>     --add-opens 
> org.junit.platform.commons/org.junit.platform.commons.logging=ALL-UNNAMED
> </argLine>
> {code}
> The failure log:
> {code:java}
> [INFO] --- maven-surefire-plugin:3.0.0-M6:test (dev) @ testing ---
> [INFO] Using auto detected provider 
> org.apache.maven.surefire.junitplatform.JUnitPlatformProvider
> [INFO] 
> [INFO] -------------------------------------------------------
> [INFO]  T E S T S
> [INFO] -------------------------------------------------------
> WARNING: Unknown module: org.junit.platform.commons specified to --add-opens
> Error: Could not find or load main class --add-opens
> Caused by: java.lang.ClassNotFoundException: --add-opens
> [INFO] 
> [INFO] Results:
> [INFO] 
> [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
> [INFO] 
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Total time:  9.157 s
> [INFO] Finished at: 2022-04-06T16:28:23-04:00
> [INFO] 
> ------------------------------------------------------------------------
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M6:test (dev) on project 
> testing: 
> {code}



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to