slawekjaranowski commented on a change in pull request #500: URL: https://github.com/apache/maven-surefire/pull/500#discussion_r835907762
########## File path: surefire-its/src/test/resources/junit5-testng/pom.xml ########## @@ -21,74 +21,73 @@ <project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> - <modelVersion>4.0.0</modelVersion> + <modelVersion>4.0.0</modelVersion> - <groupId>org.example</groupId> - <artifactId>testng-junit5</artifactId> - <version>1.0-SNAPSHOT</version> + <groupId>org.example</groupId> + <artifactId>testng-junit5</artifactId> + <version>1.0-SNAPSHOT</version> - <properties> - <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> - <maven.compiler.source>${java.specification.version}</maven.compiler.source> - <maven.compiler.target>${java.specification.version}</maven.compiler.target> - </properties> + <description>Project with mixed TestNG and JUnit5 tests.</description> - <dependencies> + <properties> + <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> + <maven.compiler.source>${java.specification.version}</maven.compiler.source> + <maven.compiler.target>${java.specification.version}</maven.compiler.target> + </properties> + + <dependencies> + <dependency> + <groupId>org.testng</groupId> + <artifactId>testng</artifactId> + <version>7.4.0</version> + <scope>test</scope> + </dependency> + <dependency> + <groupId>org.junit.support</groupId> Review comment: If engine should be not as a transitive dependency form `testng-engin` we simply should report a issue for `testng-engin` not introduce workaround here. You point me to archived project https://github.com/testng-team/testng-junit5 Now maintenanced is: https://github.com/junit-team/testng-engine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
