Tibor17 commented on a change in pull request #500: URL: https://github.com/apache/maven-surefire/pull/500#discussion_r835902757
########## File path: surefire-its/src/test/resources/junit5-testng/pom.xml ########## @@ -21,74 +21,73 @@ <project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> - <modelVersion>4.0.0</modelVersion> + <modelVersion>4.0.0</modelVersion> - <groupId>org.example</groupId> - <artifactId>testng-junit5</artifactId> - <version>1.0-SNAPSHOT</version> + <groupId>org.example</groupId> + <artifactId>testng-junit5</artifactId> + <version>1.0-SNAPSHOT</version> - <properties> - <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> - <maven.compiler.source>${java.specification.version}</maven.compiler.source> - <maven.compiler.target>${java.specification.version}</maven.compiler.target> - </properties> + <description>Project with mixed TestNG and JUnit5 tests.</description> - <dependencies> + <properties> + <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> + <maven.compiler.source>${java.specification.version}</maven.compiler.source> + <maven.compiler.target>${java.specification.version}</maven.compiler.target> + </properties> + + <dependencies> + <dependency> + <groupId>org.testng</groupId> + <artifactId>testng</artifactId> + <version>7.4.0</version> + <scope>test</scope> + </dependency> + <dependency> + <groupId>org.junit.support</groupId> Review comment: You are missing the engine exclusion in this dependency. In the previous revision, see the [POM](https://repo1.maven.org/maven2/com/github/testng-team/testng-junit5/0.0.1/testng-junit5-0.0.1.pom), the Jupiter version was 5.5.0, therefore we excluded it and the engine and api was removed as well. Adding it in the provider would mean that a new version of the engine and api would be consistent with another version. Overriding the version of API in the profile `junit5-api` would mean that the original engine stays. That's not consistent. So it's better to remove engine as a transitive dependency. The profile's responsibility would be to specify junit artifact. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
