caiwei-ebay commented on pull request #158: URL: https://github.com/apache/maven-resolver/pull/158#issuecomment-1079874235
@michael-o @cstamas @jebeaudet @ibabiankou As @cstamas pointed out, there is a slight but measurable performance downgrade with the BFS approach. mvn-df: ~/bin/apache-maven/maven-master-df/bin/mvn -Dmaven.repo.local=local-repo clean package -Drat.skip -Dtest=et -DfailIfNoTests=false Total time: 01:16 min, 28.102 s, 27.797 s Local repo: 4267 / 246336 bytes mvn-bf: ~/bin/apache-maven/maven-master-bf/bin/mvn -Dmaven.repo.local=local-repo clean package -Drat.skip -Dtest=et -DfailIfNoTests=false Total time: 01:16 min, 27.998 s, 28.542 s Local repo: 4141 / 246792 bytes Below is the commit including some minor changes to avoid object creation and array copy which might be helpful for the slight performance downgrade: https://github.com/apache/maven-resolver/pull/158/commits/6ec55082d9fc58c05bac2c986deac04fb6d0f8cf As I don't have your test project, I was verifying it by running dependency tree of spring-boot project (mvn dependency:tree -o) and saw a bit improvement (17.7s -> 17.1s). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
