Tibor17 commented on a change in pull request #495:
URL: https://github.com/apache/maven-surefire/pull/495#discussion_r834215653
##########
File path:
surefire-api/src/main/java/org/apache/maven/surefire/api/booter/BaseProviderFactory.java
##########
@@ -115,7 +118,11 @@ private int getThreadCount()
@Override
public RunOrderCalculator getRunOrderCalculator()
{
- return new DefaultRunOrderCalculator( runOrderParameters,
getThreadCount() );
+ TestListResolver testListResolver = testRequest.getTestListResolver();
Review comment:
I will try to make a proposal but currently we are before M6 release.
The integration test is very good.
The MOJO class should evaluate the string, and if e.g. regex is not
supported, throw MOJO failure exception. The string should take parallel path
along with TestListResolver during serialization, because it becomes another
information for RunOrder, but we must not use TestListResolver. The
TestListResolver has nothing to do ordering and it is not a transfer object for
`-Dtest=...`. I will try to do something but not this week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
