[ 
https://issues.apache.org/jira/browse/MNG-7432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17509351#comment-17509351
 ] 

Basil Crow commented on MNG-7432:
---------------------------------

A more minimal (and therefore likely less controversial) alternative to the fix 
proposed in [apache/maven#695|https://github.com/apache/maven/pull/695] is:

{noformat}
diff --git a/maven-core/src/main/java/org/apache/maven/DefaultMaven.java 
b/maven-core/src/main/java/org/apache/maven/DefaultMaven.java
index 56a42b724..965345394 100644
--- a/maven-core/src/main/java/org/apache/maven/DefaultMaven.java
+++ b/maven-core/src/main/java/org/apache/maven/DefaultMaven.java
@@ -377,8 +377,15 @@ private void setupWorkspaceReader( MavenSession session, 
DefaultRepositorySystem
             }
             workspaceReaders.add( workspaceReader );
         }
-        WorkspaceReader[] readers = workspaceReaders.toArray( new 
WorkspaceReader[0] );
-        repoSession.setWorkspaceReader( new ChainedWorkspaceReader( readers ) 
);
+        if ( workspaceReaders.size() == 1 )
+        {
+            repoSession.setWorkspaceReader( workspaceReaders.get( 0 ) );
+        }
+        else
+        {
+            WorkspaceReader[] readers = workspaceReaders.toArray( new 
WorkspaceReader[0] );
+            repoSession.setWorkspaceReader( new ChainedWorkspaceReader( 
readers ) );
+        }
 
     }
 {noformat}

This fixes the problem for me by restoring the old behavior from Maven 3.8.4.

> REGRESSION in 3.8.5: Dependencies from profile not picked up via 
> -P<profileName>
> --------------------------------------------------------------------------------
>
>                 Key: MNG-7432
>                 URL: https://issues.apache.org/jira/browse/MNG-7432
>             Project: Maven
>          Issue Type: Bug
>    Affects Versions: 3.8.5
>            Reporter: Falko Modler
>            Priority: Critical
>
> The README of the following reproducer says it all:
> https://github.com/aloubyansky/playground/tree/maven-3.8.5-profile-activation
> Initially discussed here: 
> https://github.com/quarkusio/quarkus/pull/24285#issuecomment-1067368625



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to