hboutemy commented on a change in pull request #478:
URL: https://github.com/apache/maven-surefire/pull/478#discussion_r823177122
##########
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireHelper.java
##########
@@ -154,7 +155,11 @@ public static void reportExecution(
SurefireReportParameters reportParameters, R
return;
}
- if ( reportParameters.isTestFailureIgnore() )
+ if ( firstForkException instanceof SurefireBooterForkException )
+ {
+ throwException( reportParameters, result, firstForkException );
Review comment:
it seems people don't agree on what `BUILD_FAILURE` and `BUILD_ERROR`
mean or have as concrete result (which I personally don't know)
and I don't know why, instead of clarifying, the discussion becomes heated
for no reason
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
