Tibor17 commented on a change in pull request #478:
URL: https://github.com/apache/maven-surefire/pull/478#discussion_r822751341
##########
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireHelper.java
##########
@@ -154,7 +155,11 @@ public static void reportExecution(
SurefireReportParameters reportParameters, R
return;
}
- if ( reportParameters.isTestFailureIgnore() )
+ if ( firstForkException instanceof SurefireBooterForkException )
+ {
+ throwException( reportParameters, result, firstForkException );
Review comment:
@olamy
@slawekjaranowski
It is extremely important due to you want to interrupt the build with
**ignoring the failure** but on the other side you let the build to say **BUILD
FAILURE**. How come? You want to ignore it. Hopefully, we have another
alternative **BUILD ERROR** which looks much more reasonable to the users and
everyone I guess.
Here matters what you do and how you do it. This is 50% of the behavior of
`maven.test.failure.ignore` because yes you stopped the build, but the next 50%
is how you present the information to the client.
I will never use the same terminology in the text with "LOL" same way as
Olivier openly does later in these comments, because this is disgusting. So
what are we going to play, a game with ego, or we would patiently evaluate
technical/business arguments?
@hboutemy
Herve, pls participate as an independent moderator here. I expect from
@olamy to be neutral and fully rational.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
