kwin edited a comment on pull request #681: URL: https://github.com/apache/maven/pull/681#issuecomment-1048057318
@michael-o This is how I think the merge is reasonable. The same named method in https://github.com/apache/maven/blob/69d6c6d5a2886bd76fa9d0e922677d4654d1d90b/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/RemoteSnapshotMetadata.java#L72 is IMHO different from `Metadata.merge()` as the former does a recessive merge but I don't think this is reasonable here, therefore I don't think we have to consider it here any further. I think it boils down to the question whether multiple or only one `snapshotVersion` is allowed per extension and classifier in https://maven.apache.org/ref/3.8.3/maven-repository-metadata/repository-metadata.html#class_snapshotVersion. I currently assume that it is multiple ones but looking at https://repository.apache.org/content/repositories/snapshots/org/apache/maven/maven-core/4.0.0-alpha-1-SNAPSHOT/maven-metadata.xml one could also think, only one SNAPSHOT version is allowed. Update: I updated the code to be in line with RemoteSnapshotMetadata.merge() now and made sure that only the most recent version per classifier/extension is listed in the metadata. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
