[GitHub] [maven-surefire] slawekjaranowski commented on a change in pull request #469: [SUREFIRE-2011] Updated abstractions which helps associating standard out/err with a test

[GitBox]

slawekjaranowski commented on a change in pull request #469:
URL: https://github.com/apache/maven-surefire/pull/469#discussion_r805308947



##########
File path: 
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/TestSetRunListener.java
##########
@@ -51,13 +50,13 @@
  * @author Kristian Rosenvold
  */
 public class TestSetRunListener
-    implements RunListener, ConsoleOutputReceiver, ConsoleLogger
+    implements TestRunListener, ConsoleLogger

Review comment:
       Ok, I can wrong
   
   On fork side 
   `ForkingRunListener` is used as ConsoleLogger
    instance of `ForkingRunListener` is created by 
`ForkingReporterFactory#createReporter` 
   
   in `ForkedBooter` I see
   ```
           forkingReporterFactory = createForkingReporterFactory();
           logger = (ConsoleLogger) forkingReporterFactory.createReporter();
   ```
   
   but when I see `ConsoleLoggerDecorator` - everything can happen in runtime
   so don't spend more time on this ... 
   maybe after more time it will be more clear for me




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org