pzygielo commented on a change in pull request #176: URL: https://github.com/apache/maven-indexer/pull/176#discussion_r805145213
########## File path: pom.xml ########## @@ -369,11 +369,16 @@ under the License. </plugins> <pluginManagement> <plugins> - <plugin><!-- TODO remove when upgrading parnet POM to 35 --> + <plugin><!-- TODO remove when upgrading parent POM to 35 --> <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-shade-plugin</artifactId> <version>3.2.4</version> </plugin> + <plugin><!-- TODO remove when upgrading parent POM to 35 --> Review comment: As there is chance that on parent upgrade this removal will not be enforced - thus perhaps line 26 deserves comment to do TODOs? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org