[ 
https://issues.apache.org/jira/browse/MNG-7400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MNG-7400:
--------------------------------
    Description: 
Currently there are two kind of {{WorkspaceReaders}} the reactor one and the 
one obtained from the {{RepositorySystemSession}} (which is eed by an IDE 
scoped component in 
{{org.apache.maven.internal.aether.DefaultRepositorySystemSessionFactory}}).

In [Tycho|https://github.com/eclipse/tycho] we have the demand to supply a 
{{WorkspaceReader}} as there is a so called "target platform" as the source of 
artifacts.

Now it does not seem correct to declare it as an IDE, and of course we don't 
want to block the IDE use-case.

Another issue is that at the time the IDE component is injected there is no 
session and thus a session scoped component won't work as well so even if we 
would use this we are rather "blind".

It would be good to have maven discover {{WorkspaceReaders}} as it discovers 
{{AbstractMavenLifecycleParticipants}} in the following way, right before the 
session is fixed:

{code:java}
for ( WorkspaceReader reader : getWorkspaceReader( session.getProjects() ) )
{
        //chain them together with the current workspace reader(s)
}
{code}

  was:
Currently there are two kind of "WorkspaceReader"s the reactor one and the one 
obtained from the RepositorySystemSession (what is feed by an 'ide' scoped 
component in 
org.apache.maven.internal.aether.DefaultRepositorySystemSessionFactory).

In [Tycho |https://github.com/eclipse/tycho] we have the demand to supply a 
WorkspaceReader as there is a so called "target platform" as the source of 
artifacts.

Now it does not seem correct to declare it as an "IDE", and of course we don't 
want to block the IDE use-case.

Another issue is that at the time the IDE component is injected there is no 
session and thus a session scoped component won't work as well so even if we 
would use this we are rather "blind".

It would be good to have maven discover WorkspaceReader's as it discovers 
AbstractMavenLifecycleParticipant's in the following way, right before the 
session is fixed:

{code:java}
for ( WorkspaceReader reader : getWorkspaceReader( session.getProjects() ) )
{
        //chain them together with the current workspace reader(s)
}
{code}







> Allow more WorkspaceReaders to participate
> ------------------------------------------
>
>                 Key: MNG-7400
>                 URL: https://issues.apache.org/jira/browse/MNG-7400
>             Project: Maven
>          Issue Type: Improvement
>            Reporter: Christoph Läubrich
>            Priority: Major
>             Fix For: 3.8.x-candidate
>
>
> Currently there are two kind of {{WorkspaceReaders}} the reactor one and the 
> one obtained from the {{RepositorySystemSession}} (which is eed by an IDE 
> scoped component in 
> {{org.apache.maven.internal.aether.DefaultRepositorySystemSessionFactory}}).
> In [Tycho|https://github.com/eclipse/tycho] we have the demand to supply a 
> {{WorkspaceReader}} as there is a so called "target platform" as the source 
> of artifacts.
> Now it does not seem correct to declare it as an IDE, and of course we don't 
> want to block the IDE use-case.
> Another issue is that at the time the IDE component is injected there is no 
> session and thus a session scoped component won't work as well so even if we 
> would use this we are rather "blind".
> It would be good to have maven discover {{WorkspaceReaders}} as it discovers 
> {{AbstractMavenLifecycleParticipants}} in the following way, right before the 
> session is fixed:
> {code:java}
> for ( WorkspaceReader reader : getWorkspaceReader( session.getProjects() ) )
> {
>       //chain them together with the current workspace reader(s)
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to