cstamas commented on a change in pull request #46: URL: https://github.com/apache/maven-plugin-tools/pull/46#discussion_r734554384
########## File path: maven-plugin-tools-api/src/main/java/org/apache/maven/tools/plugin/extractor/GroupKey.java ########## @@ -0,0 +1,83 @@ +package org.apache.maven.tools.plugin.extractor; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/** + * Group key: defines "grouping" for descriptor (based on source of extraction) and rank within + * group. + */ +public final class GroupKey + implements Comparable<GroupKey> +{ + /** + * Java group is handled a bit special: is always first to be scanned. + */ + public static final String JAVA_GROUP = "java"; Review comment: I don't want to limit (ie. by using enum): right now we are open, just add (your own) extractor to plugin and it will work. Don't want to "predefine" them. Java is ONLY one that in m-p-p has two extractors. Once we have others doubled, we can add them as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
