cstamas commented on a change in pull request #46: URL: https://github.com/apache/maven-plugin-tools/pull/46#discussion_r734553287
########## File path: maven-plugin-tools-java/src/main/java/org/apache/maven/tools/plugin/extractor/javadoc/JavaJavadocMojoDescriptorExtractor.java ########## @@ -62,11 +63,34 @@ * * @see org.apache.maven.plugin.descriptor.MojoDescriptor */ -@Component( role = MojoDescriptorExtractor.class, hint = "java-javadoc" ) +@Component( role = MojoDescriptorExtractor.class, hint = JavaJavadocMojoDescriptorExtractor.NAME ) public class JavaJavadocMojoDescriptorExtractor extends AbstractLogEnabled implements MojoDescriptorExtractor, JavadocMojoAnnotation { + public static final String NAME = "java-javadoc"; + + private static final GroupKey GROUP_KEY = new GroupKey( GroupKey.JAVA_GROUP, 200 ); + + @Override + public String getName() + { + return NAME; + } + + @Override + public boolean isDeprecated() + { + return true; // one should use Java5 annotations instead + } + + @Override + @SuppressWarnings( "checkstyle:magicnumber" ) Review comment: Checkstyle was yelling, so I added, yes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org