[GitHub] [maven] michael-o commented on a change in pull request #488: [MNG-7131] maven.config doesn't handle arguments with spaces in them

[GitBox]

michael-o commented on a change in pull request #488:
URL: https://github.com/apache/maven/pull/488#discussion_r670652684



##########
File path: maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
##########
@@ -387,7 +388,7 @@ void cli( CliRequest cliRequest )
 
             if ( configFile.isFile() )
             {
-                for ( String arg : new String( Files.readAllBytes( 
configFile.toPath() ) ).split( "\\s+" ) )
+                for ( String arg : Files.readAllLines( configFile.toPath(), 
Charset.defaultCharset() ) )

Review comment:
       Note: I have retained the original file encoding because `jvm.config` is 
subject to the same platform encoding. We can consider making `maven.config` 
UTF-8 only.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org