MartinKanters commented on a change in pull request #472:
URL: https://github.com/apache/maven/pull/472#discussion_r634710264



##########
File path: 
maven-embedder/src/main/java/org/apache/maven/cli/event/ExecutionEventLogger.java
##########
@@ -53,9 +54,15 @@
 {
     private final Logger logger;
 
-    private static final int LINE_LENGTH = 72;
+    private static final int MAX_LOG_PREFIX_SIZE = 8; // "[ERROR] "
+    private static final int PROJECT_STATUS_SUFFIX_SIZE = 20; // "SUCCESS [  
0.000 s]"
+    private static final int MIN_TERMINAL_WIDTH = 60;
+    private static final int MAX_TERMINAL_WIDTH = 130;
+    private static final int TERMINAL_WIDTH =
+            Math.min( MAX_TERMINAL_WIDTH, Math.max( 
MessageUtils.getTerminalWidth(), MIN_TERMINAL_WIDTH ) );

Review comment:
       Hmm, it's definitely better, but I think it would be best if we could 
keep this term width state in `maven-embedder`.
   What if we store it as a regular field in `ExecutionEventLogger`? Or are you 
reusing the same instance of that as well in separate runs? Otherwise we could 
find some way to recalculate it every time `projectDiscoveryStarted()` is 
called or introduce a new method for it..




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to