gnodet commented on a change in pull request #444:
URL: https://github.com/apache/maven/pull/444#discussion_r575182290
##########
File path:
maven-core/src/test/java/org/apache/maven/execution/DefaultBuildResumptionDataRepositoryTest.java
##########
@@ -54,38 +55,38 @@ public void
resumeFromPropertyDoesNotOverrideExistingRequestParameters()
MavenExecutionRequest request = new DefaultMavenExecutionRequest();
request.setResumeFrom( ":module-b" );
Properties properties = new Properties();
- properties.setProperty( "resumeFrom", ":module-a" );
+ properties.setProperty( "projectList", ":module-a" );
repository.applyResumptionProperties( request, properties );
assertThat( request.getResumeFrom(), is( ":module-b" ) );
}
@Test
- public void
excludedProjectsFromPropertyGetsAddedToExistingRequestParameters()
+ public void projectsFromPropertyGetsAddedToExistingRequestParameters()
{
MavenExecutionRequest request = new DefaultMavenExecutionRequest();
- List<String> excludedProjects = new ArrayList<>();
- excludedProjects.add( ":module-a" );
- request.setExcludedProjects( excludedProjects );
+ List<String> selectedProjects = new ArrayList<>();
+ selectedProjects.add( ":module-a" );
+ request.setSelectedProjects( selectedProjects );
Properties properties = new Properties();
- properties.setProperty( "excludedProjects", ":module-b, :module-c" );
+ properties.setProperty( "projectList", ":module-b, :module-c" );
repository.applyResumptionProperties( request, properties );
- assertThat( request.getExcludedProjects(), contains( ":module-a",
":module-b", ":module-c" ) );
+ assertThat( request.getSelectedProjects(), contains( ":module-a",
":module-b", ":module-c" ) );
}
@Test
- public void excludedProjectsAreNotAddedWhenPropertyValueIsEmpty()
+ public void SELECTEDProjectsAreNotAddedWhenPropertyValueIsEmpty()
Review comment:
That's clearly a typo !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
