gnodet commented on a change in pull request #444:
URL: https://github.com/apache/maven/pull/444#discussion_r575178829
##########
File path:
maven-core/src/main/java/org/apache/maven/execution/BuildResumptionData.java
##########
@@ -32,36 +29,20 @@
/**
* The project where the next build could resume from.
*/
- private final String resumeFrom;
-
- /**
- * List of projects to skip.
- */
- private final List<String> projectsToSkip;
+ private final List<String> projectList;
Review comment:
I'll refactor this class to change the field name and fix the javadoc.
##########
File path:
maven-core/src/main/java/org/apache/maven/execution/BuildResumptionData.java
##########
@@ -32,36 +29,20 @@
/**
* The project where the next build could resume from.
*/
- private final String resumeFrom;
-
- /**
- * List of projects to skip.
- */
- private final List<String> projectsToSkip;
+ private final List<String> projectList;
- public BuildResumptionData ( final String resumeFrom, final List<String>
projectsToSkip )
+ public BuildResumptionData ( final List<String> projectList )
{
- this.resumeFrom = resumeFrom;
- this.projectsToSkip = projectsToSkip;
+ this.projectList = projectList;
}
/**
- * Returns the project where the next build can resume from.
- * This is usually the first failed project in the order of the reactor.
- * @return An optional containing the group and artifact id of the
project. It does not make sense to resume
- * the build when the first project of the reactor has failed, so then
it will return an empty optional.
+ * Returns the projects that still need to be build when resuming.
Review comment:
See above
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
