Tibor17 commented on a change in pull request #333:
URL: https://github.com/apache/maven-surefire/pull/333#discussion_r566116951



##########
File path: 
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireHelper.java
##########
@@ -142,7 +142,9 @@ public static void reportExecution( 
SurefireReportParameters reportParameters, R
                                         PluginConsoleLogger log, Exception 
firstForkException )
         throws MojoFailureException, MojoExecutionException
     {
-        if ( firstForkException == null && !result.isTimeout() && 
result.isErrorFree() )
+        if ( firstForkException == null && !result.isTimeout() && 
result.isErrorFree()

Review comment:
       > 
   > 
   > Got it, thanks!
   > 
   > So is this option something you'd consider adding? In that case I'd flesh 
out the PR some more.
   
   Yes I would consider this PR adding to Surefire.
   Scary of the future PRs a bit ;-)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to