Tibor17 commented on a change in pull request #333: URL: https://github.com/apache/maven-surefire/pull/333#discussion_r566092236
########## File path: surefire-its/src/test/java/org/apache/maven/surefire/its/JUnitPlatformRerunFailingTestsIT.java ########## @@ -203,6 +203,19 @@ public void testRerunOneTestMethod() verifyFailuresOneRetryOneMethod( outputValidator ); } + @Test + public void testFailOnTooManyFlakes() + { + OutputValidator outputValidator = unpack().setJUnitVersion( VERSION ).maven().debugLogging() + .addGoal( "-Dsurefire.rerunFailingTestsCount=2" ) + .addGoal( "-Dsurefire.failOnFlakeCount=1" ) Review comment: Then it would become a simple test and it should perform as if `failOnFlakeCount` was disabled. Am I right? So the `failOnFlakeCount` works only with specified `rerunFailingTestsCount > 0`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org