rmannibucau commented on pull request #421: URL: https://github.com/apache/maven/pull/421#issuecomment-766138237
@mkarg hmm, for me the contract was that getPath returns either setPath or setFile value (converted with toPath if needed or the opposite). If there is no contract then don't add the methods. Also note that default has a huge bug for me - this is why I think testing default is pointless, at the end it is not a default method but an abstract method - if you impl *now* an Artifact you will impl setPath/getPath - ok, strictly speaking 50% of cases will be like that but it is tempting since it looks more modern - and not getFile/setFile....and nothing will work at all with your impl until it is an internal usage only. This is why I don't push too much this, I have no issue integrating it but I don't think it helps to have anything else than getPath *only* - but once again I have nothing against if people want. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
