rmannibucau commented on pull request #421: URL: https://github.com/apache/maven/pull/421#issuecomment-766017252
@mkarg Agree with @elharo , you dont test the contract (which is 100%) of what a default method is but its impl. There are other ways to impl it correctly and your test would fail whereas it shouldnt which tend to proove it is a test of mocks and not of contract. Since it is the last discussion point I think the fastest is to fix the test instead of discussing it is worth or not which can end up depending on people - will take you 2mn or so to fix it properly ;) - then everything will be green and it can be merged IMHO. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
