[
https://issues.apache.org/jira/browse/DOXIA-616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17257548#comment-17257548
]
ASF GitHub Bot commented on DOXIA-616:
--------------------------------------
michael-o commented on pull request #49:
URL: https://github.com/apache/maven-doxia/pull/49#issuecomment-753532426
The changeset seems to be fine. There is now expected fallout in MSITE:
```
[INFO] Building: doxia-formats/pom.xml
[INFO] run post-build script verify.groovy
[INFO] The post-build script did not succeed. assert content.contains(
'<div class="source"><pre class="prettyprint linenums">code block' )
| |
| false
<!DOCTYPE html>
<!--
| Generated by Apache Maven Doxia Site Renderer 1.9.2 from
src/site/markdown/markdown.md at 2021-01-02
| Rendered using Apache Maven Fluido Skin 1.8
-->
<html xmlns="http://www.w3.org/1999/xhtml"; lang="en">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width,
initial-scale=1" />
<meta name="generator" content="Apache Maven Doxia Site Renderer
1.9.2" />
<title>Doxia formats tests – Markdown Format works</title>
<link rel="stylesheet"
href="./css/apache-maven-fluido-1.8.min.css" />
<link rel="stylesheet" href="./css/site.css" />
<link rel="stylesheet" href="./css/print.css" media="print" />
<script src="./js/apache-maven-fluido-1.8.min.js"></script>
</head>
<body class="topBarDisabled">
<div class="container-fluid">
<header>
<div id="banner">
<div class="pull-left"><div id="bannerLeft"><h2>Doxia
formats tests</h2>
</div>
</div>
<div class="pull-right"></div>
<div class="clear"><hr/></div>
</div>
<div id="breadcrumbs">
<ul class="breadcrumb">
<li id="publishDate">Last Published: 2021-01-02<span
class="divider">|</span>
</li>
<li id="projectVersion">Version: 1.0-SNAPSHOT</li>
</ul>
</div>
</header>
<div class="row-fluid">
<header id="leftColumn" class="span2">
<nav class="well sidebar-nav">
<ul class="nav nav-list">
</ul>
</nav>
<div class="well sidebar-nav">
<hr />
<div id="poweredBy">
<div class="clear"></div>
<div class="clear"></div>
<div class="clear"></div>
<a href="http://maven.apache.org/"; title="Built by Maven"
class="poweredBy"><img class="builtBy" alt="Built by Maven"
src="./images/logos/maven-feather.png" /></a>
</div>
</div>
</header>
<main id="bodyColumn" class="span10" >
<!---
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<section>
<h2><a name="Markdown_Format_works"></a>Markdown Format works</h2>
<p>But ‘quotes’ and “double quotes” were
stripped from HTML result with DOXIA 1.3:
see <a class="externalLink"
href="https://issues.apache.org/jira/browse/DOXIA-473";>DOXIA-473</a>.</p>
<ul>
<li><a href="#Markdown_Format_works">Markdown Format works</a>
<ul>
<li><a href="#Subsection">Subsection</a></li></ul></li></ul>
<section>
<h3><a name="Subsection"></a>Subsection</h3>
<p>Missing <code>monospaced</code> support <a class="externalLink"
href="https://issues.apache.org/jira/browse/DOXIA-597";>DOXIA-597</a></p>
<p>Missing code block color <a class="externalLink"
href="https://issues.apache.org/jira/browse/DOXIA-571";>DOXIA-571</a>:</p>
<div class="source"><pre class="prettyprint linenums"><code>code block
Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: D:\apache-maven-3.6.3\apache-maven\bin\..
Java version: 1.8.0_232, vendor: AdoptOpenJDK, runtime: C:\Program
Files\AdoptOpenJDK\jdk-8.0.232.09-hotspot\jre
Default locale: en_US, platform encoding: Cp1250
OS name: "windows 10", version: "10.0", arch:
"amd64", family: "windows"
</code></pre></div></section></section>
</main>
</div>
</div>
<hr/>
<footer>
<div class="container-fluid">
<div class="row-fluid">
<p>Copyright © 2021..</p>
</div>
</div>
</footer>
</body>
</html>
[INFO] doxia-formats/pom.xml ............................ FAILED
(5.3 s)
```
Can you have a look and create a followup PR in MSITE?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Markdown: Properly expose the language specified in fenced code blocks
> ----------------------------------------------------------------------
>
> Key: DOXIA-616
> URL: https://issues.apache.org/jira/browse/DOXIA-616
> Project: Maven Doxia
> Issue Type: Improvement
> Components: Module - Markdown
> Affects Versions: 1.8, 1.9, 1.9.1
> Reporter: Bertrand Martin
> Assignee: Michael Osipov
> Priority: Major
> Fix For: 1.10
>
>
> h1. Use Case
> Writers can specify the language used in a fenced code block (typically for
> syntax highlighting), as in the example below:
> {code}
> ```java
> System.out.println("Beautiful\n");
> ```
> {code}
> Currently, the Doxia module for Markdown does not expose this information
> ("java") in the produced HTML, so a Maven skin (or frontend renderer) cannot
> leverage it.
> Produced HTML:
> {code:html}
> <div class="source"> <!-- No mention of Java :-( -->
> <pre>
> System.out.println("Beautiful\n");
> </pre>
> </div>
> {code}
> Wanted result:
> {code:html}
> <div class="source java"> <!-- :-) -->
> <pre>
> System.out.println("Beautiful\n");
> </pre>
> </div>
> {code}
> h1. Specification
> Un-comment this block:
> https://github.com/apache/maven-doxia/blob/c439714e8f4a9e86f9962ac6be9a0077ae9b4d30/doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/FlexmarkDoxiaNodeRenderer.java#L103
> This should do the trick.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
