rfscholte commented on a change in pull request #415:
URL: https://github.com/apache/maven/pull/415#discussion_r549106686
##########
File path: maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
##########
@@ -433,6 +433,8 @@ void cli( CliRequest cliRequest )
if ( cliRequest.commandLine.hasOption( CLIManager.VERSION ) )
{
+ // MNG-7032: Also disable colours if in batch mode
+ disableColorsInLogfileOrBatch( cliRequest );
Review comment:
Please move this line to line 427. I can imagine we're going to add
colors to the help output too. And maybe there will be more options in the
future. This disabling a global thing, should not be restricted to `version`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
