michael-o commented on a change in pull request #91:
URL:
https://github.com/apache/maven-integration-testing/pull/91#discussion_r548749474
##########
File path:
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4660OutdatedPackagedArtifact.java
##########
@@ -112,7 +112,9 @@ public void testShouldWarnWhenPackagedArtifactIsOutdated()
throws Exception
verifier3.verifyErrorFreeLog();
try
{
- verifier3.verifyTextInLog( "File
'module-a/target/classes/example.properties' is more recent than the packaged
artifact for 'module-a'; using 'module-a/target/classes' instead" );
+ Path path = Paths.get( "module-a", "target", "classes",
"example.properties" );
+ verifier3.verifyTextInLog( "File '" + path.toString() + "' is more
recent than the packaged artifact for 'module-a'; "
+ + "using 'module-a/target/classes' instead" );
Review comment:
Is this line portable too?
##########
File path:
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4660OutdatedPackagedArtifact.java
##########
@@ -112,7 +112,9 @@ public void testShouldWarnWhenPackagedArtifactIsOutdated()
throws Exception
verifier3.verifyErrorFreeLog();
try
{
- verifier3.verifyTextInLog( "File
'module-a/target/classes/example.properties' is more recent than the packaged
artifact for 'module-a'; using 'module-a/target/classes' instead" );
+ Path path = Paths.get( "module-a", "target", "classes",
"example.properties" );
+ verifier3.verifyTextInLog( "File '" + path.toString() + "' is more
recent than the packaged artifact for 'module-a'; "
Review comment:
the #toString() is redundant. It will be invoked automatically.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
