michael-o commented on a change in pull request #416:
URL: https://github.com/apache/maven/pull/416#discussion_r548723020
##########
File path: maven-core/src/main/java/org/apache/maven/ReactorReader.java
##########
@@ -178,41 +178,49 @@ private File find( MavenProject project, Artifact
artifact )
}
// Check whether an earlier Maven run might have produced an artifact
that is still on disk.
else if ( packagedArtifactFile != null && packagedArtifactFile.exists()
- && isPackagedArtifactUpToDate( project, packagedArtifactFile )
)
+ && isPackagedArtifactUpToDate( project, packagedArtifactFile,
artifact ) )
{
return packagedArtifactFile;
}
else if ( !hasBeenPackagedDuringThisSession( project ) )
{
// fallback to loose class files only if artifacts haven't been
packaged yet
// and only for plain old jars. Not war files, not ear files, not
anything else.
+ return determineLooseDirectoryForArtifact( project, artifact );
+ }
+
+ // The fall-through indicates that the artifact cannot be found;
+ // for instance if package produced nothing or classifier problems.
+ return null;
+ }
- if ( isTestArtifact( artifact ) )
+ private File determineLooseDirectoryForArtifact( final MavenProject
project, final Artifact artifact )
Review comment:
Since you are using a build output directory, why not use this in the
method name? `determineBuildOutputDirectoryForArtifact`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
