jtnord commented on a change in pull request #62:
URL: https://github.com/apache/maven-release/pull/62#discussion_r535076817
##########
File path:
maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PrepareReleaseMojo.java
##########
@@ -387,4 +403,27 @@ protected void prepareRelease( boolean generateReleasePoms
)
}
}
+ private String resolveLineSeparator()
+ {
+ if ( lineSeparator == null )
+ {
+ return System.getProperty( "line.separator" );
+ }
+
+ switch ( lineSeparator )
Review comment:
it would be really great if there was a "same as source" option that
sniffed the line endings in the current projects `pom.xml` and used that as the
default rather than the jvm default. this would fix MRELEASE-899 without
having to make any changes, and should not affect any user who was not affected
by MRELEASE-899 (or its inverse that \n would be used on *nix when a \r\n file
was checked out) already.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
