Tibor17 commented on a change in pull request #324:
URL: https://github.com/apache/maven-surefire/pull/324#discussion_r524263465
##########
File path:
surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/RunListenerAdapter.java
##########
@@ -124,13 +125,16 @@ public void executionFinished( TestIdentifier
testIdentifier, TestExecutionResul
}
break;
case FAILED:
+ String reason = safeGetMessage(
testExecutionResult.getThrowable().orElse( null ) );
if ( isAssertionError )
{
- runListener.testFailed( createReportEntry(
testIdentifier, testExecutionResult, elapsed ) );
+ runListener.testFailed( createReportEntry(
testIdentifier, testExecutionResult,
+ reason, elapsed ) );
}
else
{
- runListener.testError( createReportEntry(
testIdentifier, testExecutionResult, elapsed ) );
+ runListener.testError( createReportEntry(
testIdentifier, testExecutionResult,
Review comment:
The method `createReportEntry( testIdentifier, testExecutionResult,
reason, elapsed )` is called twice.
Maybe you can call it once and move it between the Line 128 and 129.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
