mabrarov edited a comment on pull request #24: URL: https://github.com/apache/maven-ear-plugin/pull/24#issuecomment-727563337
@ rfscholte, Regarding [your question](/apache/maven-ear-plugin/pull/24#pullrequestreview-530790385). > there will be a request to select per module which artifacts should be moved to the (shared) lib directory. Do you mean "select skinny mode (move all or nothing) per module and not for all modules"? If yes, then here are my thoughts: I thought about the same but then decided that `skinnyWars` option doesn't provide such ability so that `skinnyModules` option can follow the same approach. > Would such a change fit in this PR without adjusting the new parameters? We can add both: 1. `skinnyModules` option of plugin configuration (implemented) 1. `skinny` property of EAR module which default value is equal to `skinnyModules` option of plugin configuration (`skinnyModules || skinnyWars` for web module). `skinny == false` will work the same way (will lead to the same) as when `libDirectory == null` (it's not possible to specify `null` value for `libDirectory` property of EAR module at the moment). That way we can use global configuration (when we need just all modules) and choose what modules to make "skinny / non-skinny" when required (`skinnyModules == true` in configuration and `skinny == false` for the modules which need to be non-skinny or default / omitted `skinnyModules` and `skinny == true` for the modules which need to be skinny). If you mean choosing subset of EAR module libraries to move into EAR shared lib directory, then we can add this feature too by implementing some artifact filter (`skinnyLibFilter`) as property of EAR module, but this looks more complicated (to understand and to implement). My main concern against making all these changes (which complicate implementation and understanding) is that I'm not sure if this feature is really wanted by users of Maven EAR Plugin - I never had a need of anything like that: 1. to move into shared EAR lib directory just a part of EAR module libraries 1. to make some modules of EAR skinny while other - non-skinny. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
