mabrarov commented on a change in pull request #24:
URL: https://github.com/apache/maven-ear-plugin/pull/24#discussion_r507837640
##########
File path: src/main/java/org/apache/maven/plugins/ear/EarMojo.java
##########
@@ -739,6 +751,11 @@ public boolean isNonFilteredExtension( String fileName )
private void changeManifestClasspath( EarModule module, File original,
JavaEEVersion javaEEVersion )
throws MojoFailureException
{
+ final String moduleLibDir = module.getLibDir();
+ if ( !( moduleLibDir == null || skinnyModules || skinnyWars && module
instanceof WebModule ) )
Review comment:
Addressed in 83a46e0
##########
File path: src/main/java/org/apache/maven/plugins/ear/EarMojo.java
##########
@@ -799,16 +816,16 @@ private void changeManifestClasspath( EarModule module,
File original, JavaEEVer
classPath = new Attribute( "Class-Path", "" );
}
- // Remove JAR modules
- for ( JarModule jm : getAllJarModules() )
+ if ( moduleLibDir != null && ( skinnyModules || skinnyWars &&
module instanceof WebModule ) )
Review comment:
Addressed in 83a46e0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
