[
https://issues.apache.org/jira/browse/MJAVADOC-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17181211#comment-17181211
]
Jin Xu edited comment on MJAVADOC-657 at 8/20/20, 2:04 PM:
-----------------------------------------------------------
[~elharo]
Hi.
This bug happens when we have a private function who have an attribute, and we
invoke "fix".
For example,
Before I do this pr, after calling "fix",
{code:java}
/**
* private constructor with annotation
*/
@SuppressWarnings("SameReturnValue")
private ClassWithJavadoc( Integer i )
{
}
{code}
will become:
{code:java}
/**
* private constructor with annotation
*/
@SuppressWarnings("SameReturnValue")
@SuppressWarnings("SameReturnValue")
private ClassWithJavadoc( Integer i )
{
}
{code}
The same bug also exist in private constructor functions.
You can see more details in the tests I added, or port the tests to original
codes and run the test to see how it fails.
was (Author: xenoamess):
[~elharo]
Hi.
This bug happens when we have a private function who have an attribute, and we
invoke "fix".
For example,
Before I do this pr, after calling "fix",
{code:java}
/**
* private constructor with annotation
*/
@SuppressWarnings("SameReturnValue")
private ClassWithJavadoc( Integer i )
{
}
{code}
will become:
{code:java}
/**
* private constructor with annotation
*/
@SuppressWarnings("SameReturnValue")
@SuppressWarnings("SameReturnValue")
private ClassWithJavadoc( Integer i )
{
}
{code}
The same bug also exist in private constructor functions.
You can see more details in the tests I added.
> found a bug about wrongly handling annotations when using fix operation
> -----------------------------------------------------------------------
>
> Key: MJAVADOC-657
> URL: https://issues.apache.org/jira/browse/MJAVADOC-657
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Reporter: Jin Xu
> Priority: Critical
>
> [https://github.com/apache/maven-javadoc-plugin/pull/52]
> Hi.
> There be several bugs happened during my usage of maven-javadoc-plugin.
> Now I found some time to report them.
> I add it in unit test(and it will fail the test now) in this pr, showing when
> it happens, how it will harm the codes, and what be the expected result.
> Now I'm being looking up the sources to see if I can fix it by myself, but I
> think it be good to let you know about the bug before I started.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
