chrisbeckey commented on pull request #72: URL: https://github.com/apache/maven-wagon/pull/72#issuecomment-669998232
regarding: "Is it really 1.11? If yes, then this is a bug in Maven." Just to be sure I tested it with "1.11" and with "11" and they both worked. I then tried with "12" (I'm running JDK 11) and it failed with the expected missing package. I think it works either way. regarding: "per-server config rather than global." I agree, is there an example you can point me to that I can start from? On Thu, Aug 6, 2020 at 11:17 AM Michael Osipov <notificati...@github.com> wrote: > > *This email was sent from an external source so please treat with caution.* > ------------------------------ > *@michael-o* commented on this pull request. > > ------------------------------ > > In wagon-providers/pom.xml > <https://github.com/apache/maven-wagon/pull/72#discussion_r466472750> > : > > > @@ -78,4 +78,20 @@ under the License. > <scope>test</scope> > </dependency> > </dependencies> > + > + <profiles> > + <profile> > + <id>jdk11</id> > + <activation> > + <jdk>[1.11,)</jdk> > > Is it really 1.11? If yes, then this is a bug in Maven. > ------------------------------ > > In > wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java > <https://github.com/apache/maven-wagon/pull/72#discussion_r466474091> > : > > > @@ -279,6 +296,13 @@ public boolean isStreaming() > private static final boolean SSL_ALLOW_ALL = > Boolean.valueOf( System.getProperty( "maven.wagon.http.ssl.allowall", "false" ) ); > > + /** > + * If enabled, then the content-type HTTP header will be set using the file extension to determine the type, > + * <b>disabled by default</b> > + * This flag is only effective when uploading from a File, not directly from a Stream. > + */ > + private static final boolean SET_CONTENT_TYPE_FROM_FILE_EXTENSION = > > I wonder whether this should be a per-server config rather than global. In > general, sys props are either globally or for a technical reason. WDYT? > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/maven-wagon/pull/72#pullrequestreview-462598973>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AMYZJ7EINPE3U7SSVUIEOODR7LCITANCNFSM4PWVNA4A> > . > About Ascential plc: Ascential (LSE:ASCL.L) is a specialist information, data and analytics company that helps the world’s most ambitious businesses win in the digital economy. Our information, insights, connections, data and digital tools solve customer problems in three disciplines: Product Design via global trend forecasting service WGSN; Marketing via global benchmark for creative excellence and effectiveness Cannes Lions and WARC and strategic advisory firm MediaLink; and Sales via ecommerce-driven data, insights and advisory service Edge by Ascential, leading managed services provider for Amazon Flywheel Digital, the world's premier payments and Fin Tech congress Money20/20, global retail industry summit World Retail Congress and retail news outlet Retail Week. Ascential also powers political, construction and environmental intelligence brands DeHavilland, Glenigan and Groundsure. The information in or attached to this email is confidential and may be legally privileged. If you are not the intended recipient of this message, any use, disclosure, copying, distribution or any action taken in reliance on it is prohibited and may be unlawful. If you have received this message in error, please notify the sender immediately by return email and delete this message and any copies from your computer and network. Ascential does not warrant that this email and any attachments are free from viruses and accepts no liability for any loss resulting from infected email transmissions. Ascential reserves the right to monitor all email through its networks. Any view expressed may be those of the originator and not necessarily of Ascential plc. Please be advised all phone calls may be recorded for training and quality purposes and by accepting and/or making calls to us you acknowledge and agree to calls being recorded. Ascential plc, number 9934451 (England and Wales). Registered Office: The Prow, 1 Wilder Walk, London W1B 5AP. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
