michael-o commented on a change in pull request #72:
URL: https://github.com/apache/maven-wagon/pull/72#discussion_r466472750



##########
File path: wagon-providers/pom.xml
##########
@@ -78,4 +78,20 @@ under the License.
       <scope>test</scope>
     </dependency>
   </dependencies>
+
+  <profiles>
+    <profile>
+      <id>jdk11</id>
+      <activation>
+        <jdk>[1.11,)</jdk>

Review comment:
       Is it really 1.11? If yes, then this is a bug in Maven.

##########
File path: 
wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java
##########
@@ -279,6 +296,13 @@ public boolean isStreaming()
     private static final boolean SSL_ALLOW_ALL =
         Boolean.valueOf( System.getProperty( "maven.wagon.http.ssl.allowall", 
"false" ) );
 
+    /**
+     * If enabled, then the content-type HTTP header will be set using the 
file extension to determine the type,
+     * <b>disabled by default</b>
+     * This flag is only effective when uploading from a File, not directly 
from a Stream.
+     */
+    private static final boolean SET_CONTENT_TYPE_FROM_FILE_EXTENSION =

Review comment:
       I wonder whether this should be a per-server config rather than global. 
In general, sys props are either globally or for a technical reason. WDYT? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to