[ 
https://issues.apache.org/jira/browse/MRESOURCES-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17159249#comment-17159249
 ] 

Dennis Lundberg commented on MRESOURCES-171:
--------------------------------------------

Thanks for the feedback [~afloom] !

I have updated the requirements list in the previous comment, to make it 
clearer.

The goal is to make the warning as unobtrusive as we possibly can. But, yes, 
there will be cases when you will need to configure the new parameter to avoid 
the warning. The example you give is one of those. This is of course 
unfortunate, but in the previous discussions we have concluded that we should 
not use convention over configuration here, simply because it will break some 
builds. The alternative we have is to inform those whose current builds might 
be broken, they just do not know it yet.

We are at a similar place we where way back in 2008, when we changed the INFO 
to a WARN if no encoding was specified. Some people will get annoyed by the 
WARN cluttering their build logs. I know, I'm one of those people :) But unless 
we have a good solid convention over configuration to rely on all we can do is 
nag our users to make an informed decision that fits their project.

> ISO8859-1 properties files get changed into UTF-8 when filtered
> ---------------------------------------------------------------
>
>                 Key: MRESOURCES-171
>                 URL: https://issues.apache.org/jira/browse/MRESOURCES-171
>             Project: Maven Resources Plugin
>          Issue Type: Bug
>          Components: filtering
>            Reporter: Alex Collins
>            Priority: Minor
>         Attachments: filtering-bug.zip
>
>
> Create:
> src/main/resources/test.properties
> And add a ISO8859-1 character that is not ASCII or UTF-8, do not use \uXXXX 
> formatting.
> When adding this line:
> <resource><directory>src/main/resources</directory><filtering>true</filtering></resource>
> Expected:
> ISO8859-1 encoded file in jar.
> Actual:
> UTF-8 encoded file in jar.
> ---
> If there are any property files (which can only be ISO8859-1) they appear to 
> be converted into UTF-8 in the jar.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to