[jira] [Comment Edited] (SUREFIRE-1633) [JUnit5 follow-up #1343] JUnit Jupiter @Nested tests do not run when selecting enclosing class with Surefire

[Vincent Massol (Jira)]

    [ 
https://issues.apache.org/jira/browse/SUREFIRE-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17131241#comment-17131241
 ] 

Vincent Massol edited comment on SUREFIRE-1633 at 6/10/20, 5:24 PM:
--------------------------------------------------------------------

*ok my bad. I mixed up {{-Dtest}} and {{-Dit.test}} in my tests so forget what 
I said above. Sorry about that!*

I tried again with adding what you suggested and ran it with the proper command 
line: {{mvn clean install 
-Dit.test=org.xwiki.wiki.test.ui.AllIT.NestedWikiTemplateIT*}}

and I get:

{noformat}
[INFO] --- maven-surefire-plugin:2.22.2:test (default-test) @ 
xwiki-platform-wiki-test-docker ---
[INFO] 
[INFO] --- maven-jar-plugin:3.2.0:jar (default-jar) @ 
xwiki-platform-wiki-test-docker ---
[INFO] Building jar: 
/Users/vmassol/dev/xwiki/xwiki-platform/xwiki-platform-core/xwiki-platform-wiki/xwiki-platform-wiki-test/xwiki-platform-wiki-test-docker/target/xwiki-platform-wiki-test-docker-12.5-SNAPSHOT.jar
[INFO] 
[INFO] --- maven-failsafe-plugin:2.22.2:integration-test (functional-tests) @ 
xwiki-platform-wiki-test-docker ---
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  19.220 s
[INFO] Finished at: 2020-06-10T19:21:18+02:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-failsafe-plugin:2.22.2:integration-test 
(functional-tests) on project xwiki-platform-wiki-test-docker: No tests were 
executed!  (Set -DfailIfNoTests=false to ignore this error.) -> [Help 1]
{noformat}

To be clear I've tried with:

{code}
  <build>
    <testSourceDirectory>src/test/it</testSourceDirectory>
    <plugins>
      <plugin>
        <groupId>org.apache.maven.plugins</groupId>
        <artifactId>maven-failsafe-plugin</artifactId>
        <configuration>
          <includes>
            <include>**/AllIT.java</include>
            <include>**/*IT.java</include>
            <include>**/IT*.java</include>
          </includes>
        </configuration>
      </plugin>
    </plugins>
  </build>
{code}

And

{code}
public class AllIT
{
    @Nested
    @DisplayName("Wiki Manager REST Panels Tests")
    class NestedWikiManagerRestIT extends WikiManagerRestIT
    {
    }

    @Nested
    @DisplayName("Wiki Template Tests")
    class NestedWikiTemplateIT
    {
        @Test
        void xxx()
        {
            assertTrue(true);
        }
    }

    @Nested
    @DisplayName("Tests using a subwiki")
    class NestedSubWikiIT extends SubWikiIT
    {
    }
}
{code}


was (Author: vmassol):
ok my bad. I mixed up {{-Dtest}} and {{-Dit.test}} in my tests so forget what I 
said above. Sorry about that!

I tried again with adding what you suggested and ran it with the proper command 
line: {{mvn clean install 
-Dit.test=org.xwiki.wiki.test.ui.AllIT.NestedWikiTemplateIT*}}

and I get:

{noformat}
[INFO] --- maven-surefire-plugin:2.22.2:test (default-test) @ 
xwiki-platform-wiki-test-docker ---
[INFO] 
[INFO] --- maven-jar-plugin:3.2.0:jar (default-jar) @ 
xwiki-platform-wiki-test-docker ---
[INFO] Building jar: 
/Users/vmassol/dev/xwiki/xwiki-platform/xwiki-platform-core/xwiki-platform-wiki/xwiki-platform-wiki-test/xwiki-platform-wiki-test-docker/target/xwiki-platform-wiki-test-docker-12.5-SNAPSHOT.jar
[INFO] 
[INFO] --- maven-failsafe-plugin:2.22.2:integration-test (functional-tests) @ 
xwiki-platform-wiki-test-docker ---
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  19.220 s
[INFO] Finished at: 2020-06-10T19:21:18+02:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-failsafe-plugin:2.22.2:integration-test 
(functional-tests) on project xwiki-platform-wiki-test-docker: No tests were 
executed!  (Set -DfailIfNoTests=false to ignore this error.) -> [Help 1]
{noformat}

To be clear I've tried with:

{code}
  <build>
    <testSourceDirectory>src/test/it</testSourceDirectory>
    <plugins>
      <plugin>
        <groupId>org.apache.maven.plugins</groupId>
        <artifactId>maven-failsafe-plugin</artifactId>
        <configuration>
          <includes>
            <include>**/AllIT.java</include>
            <include>**/*IT.java</include>
            <include>**/IT*.java</include>
          </includes>
        </configuration>
      </plugin>
    </plugins>
  </build>
{code}

And

{code}
public class AllIT
{
    @Nested
    @DisplayName("Wiki Manager REST Panels Tests")
    class NestedWikiManagerRestIT extends WikiManagerRestIT
    {
    }

    @Nested
    @DisplayName("Wiki Template Tests")
    class NestedWikiTemplateIT
    {
        @Test
        void xxx()
        {
            assertTrue(true);
        }
    }

    @Nested
    @DisplayName("Tests using a subwiki")
    class NestedSubWikiIT extends SubWikiIT
    {
    }
}
{code}

> [JUnit5 follow-up #1343] JUnit Jupiter @Nested tests do not run when 
> selecting enclosing class with Surefire
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: SUREFIRE-1633
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1633
>             Project: Maven Surefire
>          Issue Type: Bug
>          Components: JUnit 5.x support
>            Reporter: Christian Stein
>            Priority: Major
>             Fix For: Backlog
>
>
> https://github.com/junit-team/junit5/issues/1343



--
This message was sent by Atlassian Jira
(v8.3.4#803005)