[ 
https://issues.apache.org/jira/browse/MSHADE-363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17108977#comment-17108977
 ] 

Andy Wilkinson edited comment on MSHADE-363 at 5/16/20, 10:17 AM:
------------------------------------------------------------------

Following up on the suggestion to use {{PropertiesTransformer}}, unfortunately 
it does not meet our needs. Boot’s transformer combines values for the same key 
by comma separating them, i.e we merge the values rather than overriding.


was (Author: awilkinson):
Following up on the suggestion to use {{PropertiesTransformer}, unfortunately 
it does not meet our needs. Boot’s transformer combines values for the same key 
by comma separating them, i.e we merge the values rather than overriding.

> Breaking change to ResourceTransformer's API
> --------------------------------------------
>
>                 Key: MSHADE-363
>                 URL: https://issues.apache.org/jira/browse/MSHADE-363
>             Project: Maven Shade Plugin
>          Issue Type: Bug
>    Affects Versions: 3.2.3
>            Reporter: Andy Wilkinson
>            Assignee: Herve Boutemy
>            Priority: Major
>             Fix For: 3.2.4
>
>
> A Spring Boot user has [made us 
> aware|https://github.com/spring-projects/spring-boot/issues/21128] of a 
> [breaking change to the API of 
> ResourceTransformer|https://github.com/apache/maven-shade-plugin/commit/0d7bfb53a5fd83eede7edfd5552db5fa561d6286#diff-f09094e2212bb4d1173a4e183635b958]
>  in 3.2.3.
> Ideally, we don't want to require a specific version of the Shade plugin. 
> While I think we may be able to support the new and old both variants of the 
> method, it would be preferable if future 3.2.x releases are backwards 
> compatible with 3.2.2.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to