michael-o commented on a change in pull request #32: [MRELEASE-549] Add support 
for the "--pin-externals" operations in SCM branch and tag operations
URL: https://github.com/apache/maven-release/pull/32#discussion_r370071421
 
 

 ##########
 File path: 
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/ScmTagPhase.java
 ##########
 @@ -120,13 +120,16 @@ public ReleaseResult execute( ReleaseDescriptor 
releaseDescriptor, ReleaseEnviro
                 new ScmTagParameters( releaseDescriptor.getScmCommentPrefix() 
+ "copy for tag " + tagName );
             scmTagParameters.setRemoteTagging( 
releaseDescriptor.isRemoteTagging() );
             scmTagParameters.setScmRevision( 
releaseDescriptor.getScmReleasedPomRevision() );
+            scmTagParameters.setPinExternals( 
releaseDescriptor.isPinExternals() );
             if ( getLogger().isDebugEnabled() )
             {
                 getLogger().debug(
                     "ScmTagPhase :: scmTagParameters remotingTag " + 
releaseDescriptor.isRemoteTagging() );
                 getLogger().debug(
                     "ScmTagPhase :: scmTagParameters scmRevision " + 
releaseDescriptor.getScmReleasedPomRevision() );
                 getLogger().debug( "ScmTagPhase :: fileSet  " + fileSet );
+                getLogger().debug(
+                    "ScmTagPhase :: scmTagParameters pinExternals " + 
releaseDescriptor.isPinExternals() );
 
 Review comment:
   Move this up to the other parameter logging.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to