suztomo commented on issue #277: [MNG-6732] - 
DefaultArtifactDescriptorReader.loadPom to check IGNORE_MISSING policy upon 
ArtifactTransferException
URL: https://github.com/apache/maven/pull/277#issuecomment-576905166
 
 
   Memo for myself:
   
   Non-existent artifact (guava:30.0 below) causes mvn command failure but 
checksum verification failure doesn't. They both seem to go the same code path 
around this `ArtifactResolutionException`  now with this PR; IGNORE_MISSING was 
true. I guess the latter (checksum verification failure) did not go `return 
null` before this PR. Isn't the code in this PR supposed to throw 
`ArtifactDescriptorException` upon the missing artifact case? Isn't the 
IGNORE_MISSING flag controlling whether the build should fail or not?  
   
   ```
     <dependencies>
       <dependency>
         <groupId>com.google.guava</groupId>
         <artifactId>guava</artifactId>
         <version>30.0</version> <!-- does not exist -->
       </dependency>
       <!--
       <dependency>
         <groupId>org.apache.maven.its.mng3470</groupId>
         <artifactId>dep</artifactId>
         <version>0.1</version>
       </dependency>
       -->
     </dependencies>
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to